963021 - [Messages][Refresh] Add CSS tweaks for SMS based on new List component from BB.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Due to the new styles of the list, we need to add the tweaks needed for SMS App.

Comment 1

[Jason Smith [:jsmith]]

VD refresh issues are not blockers for the release, so not blocking.

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: bug.png

After Applying patch: https://github.com/mozilla-b2g/gaia/pull/17888
we get that screen, so we need to remove the rounded border in empty images.

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8410927 [details] [review]
patch in github

looks good but would look better with a unit test ;)

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: after_patch.png

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8410927 [details] [review]
patch in github

As promised, I added a unit test for this function. I didn't add tests for everything the function does, only for what you added.

Writing unit tests, I found some issues, so I commented about them :)

Then you can ask review from borja or Steve.

Thanks !

Comment 7

[Borja Salguero [:borjasalguero]]

Comment on attachment 8410927 [details] [review]
patch in github

Some comments in Github. Ask me to review this again when ready! Thanks!

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8410927 [details] [review]
patch in github

Could you please review it again? PR updated with your comments in GH.

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 74cffb8bacd5d4c128e5e55f2ec710b2eb60a9dc

Comment 10

[Loli (:lolimartinezcr)]

Tested
1.5
Hamachi
Gecko:177f146
Gaia:4788795